8000 Adm 839 [frontend] by pfpatrick · Pull Request #1127 · au-heartbeat/Heartbeat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adm 839 [frontend] #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2024
Merged

Adm 839 [frontend] #1127

merged 1 commit into from
Mar 7, 2024

Conversation

pfpatrick
Copy link

Summary

...

Before

Description

Screenshots
If applicable, add screenshots to help explain behavior of your code.

After

Description

Screenshots
If applicable, add screenshots to help explain behavior of your code.

Note

Null

@pfpatrick pfpatrick requested a review from WSSsssss33 March 7, 2024 05:07
@github-actions GitHub Actions
Copy link
github-actions bot commented Mar 7, 2024

Hi @pfpatrick! 👋
Thank you for submitting a pull request! We appreciate your contribution and will review your changes as soon as possible.

@codacy-production Codacy Production
Copy link
codacy-production bot commented Mar 7, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.00% ✅ 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8531108) 5754 5754 100.00%
Head commit (7e37dd4) 11510 (+5756) 11510 (+5756) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1127) 5 5 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed for 'heartbeat-backend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed for 'au-heartbeat-heartbeat-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

WSSsssss33
WSSsssss33 approved these changes Mar 7, 2024
View reviewed changes
Copy link
@WSSsssss33 WSSsssss33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WSSsssss33 WSSsssss33 merged commit a3d81bc into main Mar 7, 2024
@WSSsssss33 WSSsssss33 deleted the ADM-839-add-test branch March 7, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WSSsssss33 WSSsssss33 WSSsssss33 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pfpatrick @WSSsssss33
0