Remove invalid use of `memccpy()` #80

krader1961 · 2017-10-24T21:11:57Z

The behavior of the memccpy() function is undefined when the buffers
overlap which is sometimes true for the sfputr() function. So always
use an explicit loop to copy the data.

Fixes #78

The behavior of the `memccpy()` function is undefined when the buffers overlap which is sometimes true for the `sfputr()` function. So always use an explicit loop to copy the data. Fixes #78

krader1961 · 2017-10-24T21:16:35Z

You might argue that we should still use memccpy() where it is known to handle overlapping buffers (e.g., glibc on x86). But that's dangerous. It would probably never happen but theoretically a future libc release could change the implementation such that overlapping buffers are no longer handled. More importantly, just because glibc on x86 handles this situation that is no guarantee that glibc on another architecture (e.g., ppc) will do so. Thus you can't use a blacklist like the code currently does. You have to use a whitelist. And as I noted in issue #78 the added complexity isn't justified.

Remove invalid use of memccpy()

caf10a7

The behavior of the `memccpy()` function is undefined when the buffers overlap which is sometimes true for the `sfputr()` function. So always use an explicit loop to copy the data. Fixes #78

siteshwar merged commit ad83a87 into att:beta Oct 25, 2017

krader1961 deleted the memccpy branch November 11, 2017 04:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove invalid use of `memccpy()` #80

Remove invalid use of `memccpy()` #80

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Remove invalid use of memccpy() #80

Remove invalid use of memccpy() #80

Uh oh!

Conversation

Uh oh!

Uh oh!

Uh oh!

Remove invalid use of `memccpy()` #80

Remove invalid use of `memccpy()` #80