opcodesswitch: fix: OP_BS_GET_UTF16/32 flags decoding #1722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, because I'm reimplementing opcodeswitch for JIT, could we have a test for this? It will help ensuring compatibility of JIT implementation. |
Fixes "Passing a term to a function expecting a non-term" CodeQL warning. Signed-off-by: Davide Bettio <davide@uninstall.it>
BitstringFlags values are coming from flags encoding in istructions such as bs_get_utf16. Signed-off-by: Davide Bettio <davide@uninstall.it>
e3c6555 to
ba6a22d
Compare
it was just a red herring, I fixed the warning and added a short comment, no additional work is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flags must be converted with DECODE_FLAGS_LIST before using them. Fixes "Passing a term to a function expecting a non-term" CodeQL error.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later