Use _Static_assert to check macro lengths #1471
Draft
+18
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7dbf999 to
2bb0dd7
Compare
Signed-off-by: Paul Guyot <pguyot@kallisys.net>
2bb0dd7 to
2ae1afd
Compare
jgonet
approved these changes
Jan 17, 2025
jgonet
reviewed
Jan 17, 2025
Comment on lines
+27
to
+30
| #define X(name, lenstr, str) \ | ||
| _Static_assert(*lenstr == strlen(str), "Macro length mismatch for " # name); | ||
| #include "platform_defaultatoms.def" | ||
| #undef X |
There was a problem hiding this comment.
Maybe using assert.h with static_assert() would be a bit nicer.
bettio
reviewed
Jan 18, 2025
| @@ -23,10 +23,15 @@ | |||
| #include <stdlib.h> | |||
| #include <string.h> | |||
|
|
|||
| // About X macro: https://en.wikipedia.org/wiki/X_macro | |||
| #define X(name, lenstr, str) \ | |||
| _Static_assert(*lenstr == strlen(str), "Macro length mismatch for " # name); | |||
There was a problem hiding this comment.
I was waiting this check for quite some time, let's enable it only with clang >= 17. That will be enough at least for blocking any PR that introduces some atom length bug.
bettio
requested changes
Jan 18, 2025
|
I think we should just enable this on the right version of clang, and then merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
<
2C4F
span class="js-resolved-thread">This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later