beep on unrecognized commands to warn the user #781
Conversation
|
Let me see if I understand... The problem with #764 was that vim-mode thinks that it knows all possible key combinations... So, if vim-surround adds a new combination, vim-mode wouldn't recognize it and cancel it before it's complete? Wouldn't this fix suffer the same issue...? It would beep every time it sees the unrecognized combo, even though vim-surround would do the right thing? |
|
This one only beeps when a single-key keystroke hasn't been matched. The problem with #764 is that it needs to react to multi-key keystrokes. Examples: In With vim-surround, the existence of the key strokes starting with In here - #781 - there's no canceling, just beeping, and only on single-key unmatched bindings. Which brings me to an idea that #764 could only cancel on single-key unmatched bindings. That should take care of interactions with vim-surround. We'll see momentarily. |
e68ed45 to
b67f88e
Compare
|
I think I prefer this approach (beep on unrecognized key strokes, without canceling any) to the approach of #764 which tries to cancel pending commands but may delay user feedback. Neither of these two PRs can copy VIM's behaviour, but it's about handling erroneous input so there should be no consideration of muscle memory. |
|
oh boy, tiny merge conflict with #827 - I'll be happy to rebase as soon as that one is merged |
b67f88e to
c6a4080
Compare
|
OK, this one is now ready; please see my comment above when considering this. |
|
As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions! |
Alternative to #764. Instead of trying to cancel an operation, possibly running into conflict with other packages' key bindings (as discussed in #764), this PR just beeps on unrecognised key bindings.
Together with some form of showing the current pending key strokes (thought in progress), this could be a way of handling unrecognised commands that's more appropriate for Atom, even though it doesn't behave exactly like VIM.
Discussion welcome.