8000 give operator-pending mode a rectangle cursor by bronson · Pull Request #779 · atom/vim-mode · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Apr 6, 2018. It is now read-only.

give operator-pending mode a rectangle cursor #779

Merged
merged 2 commits into from
Jul 23, 2015

Conversation

bronson
Copy link
Contributor
@bronson bronson commented Jul 18, 2015

As discussed in #777

@bronson
Copy link
Contributor Author
bronson commented Jul 18, 2015

Edit: updated this PR to use the same cursor style as Vim and Jacek's code. Obviously!

I'll leave the .gifs... rectangle cursor on the left, vim cursor on the right:

bug3 bug3

@bronson
Copy link
Contributor Author
bronson commented Jul 18, 2015

Now we just need an expecting-a-character cursor that can be used for f, t, and register commands.

@@ -20,6 +20,15 @@
opacity: 0.5;
}

.low-block-cursor(@visibility: visible) {
border: none;
border-bottom: 10px solid @syntax-cursor-color;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may I suggest .6em rather than 10px here? When I pasted my custom styles, I didn't remember to change to relative units.

@bronson
Copy link
Contributor Author
bronson commented Jul 18, 2015

Agreed, updated.

@maxbrunsfeld
Copy link
Contributor

👏 Nice.

@bronson
Copy link
Contributor Author
bronson commented Jul 23, 2015

Rebased to master.

maxbrunsfeld pushed a commit that referenced this pull request Jul 23, 2015
give operator-pending mode a rectangle cursor
@maxbrunsfeld maxbrunsfeld merged commit ffec3b8 into atom:master Jul 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0