Add subword movement support #769
Conversation
As far as I understand it currently works as expected.
atom/atom@ba3ab41 changed the behavior of the subword regex. Now, for example, if moving the cursor with alt-right, the end of line and beginning of the next line will also be jumped to. This is inconsistent with how ctrl-right behaves.
|
atom/atom@ba3ab41 from atom/atom#7612 makes the subword regex match line endings if there's any trailing whitespace and line beginnings if it's followed by any whitespace. I currently worked around it, but I think the regex should be changed. |
This reverts commit 145e60f. # Conflicts: # spec/motions-spec.coffee
|
Can someone please help me figure out why some of the tests fail when I use alt as a modifier? They seem to work just fine when actually used. I tried messing around with the way the spec-helper dispatches keyboard events, but to no avail. |
|
This is a guess: it seems to me that CI is complaining about the presence of focused specs. Please try changing |
|
I like the procedurally generated tests with |
|
I'd kept the focused specs because I hadn't really gotten them to pass on my own machine yet and wasn't worrying too much about the CI build. I added a commit to change that now, however, so that the CI logs would show the actual problem I'm facing. |
for some reason, moving by subword makes the cursor stop at the space before the added equals sign, instead of stopping on it, as expected
8554a17 to
5b30698
Compare
5b30698 to
9600b31
Compare
|
Not working on this anymore |
I will be fleshing out some ideas for #377 in this PR. Comments and feedback are welcome. When all of the main changes are made and you agree and are happy with them, I can clean up the commit history and add the necessary documentation etc.
The general idea is that there will be 3 different definitions of a word. The main one, an alternative one and the space delimited (WORD) one. The only difference between the main and the alt one would be that one of them would be sensitive to camel (and snake?) casing and the other would not.
TODO: