This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Suppress line measurement exceptions and gather data to solve them #7778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 7, 2015 19:29
Don’t assume anything about metadata. Just give assertion callers access to the error object. Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
nathansobo
pushed a commit
that referenced
this pull request
Jul 8, 2015
…ceptions Suppress line measurement exceptions and gather data to solve them
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code recovers gracefully from situations where we try to measure off the end of a text node. Since this situation is unexpected, when it happens, we ask the user (only once) for the text of the line where it's happening. Hopefully we can use this information to get a better understanding of why this is happening.