This repository was archived by the owner on Mar 3, 2023. It is now read-only.
⬆️ electron-packager@12.2.0 #19318
Merged
⬆️ electron-packager@12.2.0 #19318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi there were a few more changes made in the PR to upgrade to 11.x by the author of electron-packager: #15431 |
|
They're not necessary, but they do clean up the packaging code a lot. |
|
Oh thanks for the heads up @50Wliu ! Didn't know that that PR existed! I'm gonna cherry pick the relevant changes from there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the version of
electron-packagerused by Atom to almost the latest one (latest one is 13.0.1 but I thought it would be sensible to use the previous major, which has many more minor and patch releases under its belt).The main reason for the update is to prepare for a future Electron v4 upgrade which will require electron/packager#894 to be able to work (I found that while exploring to upgrade to Electron v4 directly).
Since the new version of
electron-packagershould be compatible with both electron v2 and v3, better to upgrade right now (and find potential issues now) than when doing the electron upgrade.The list of changes between v7.3.0 and v12.2.0 is huge (v7.3.0 is a 3 year old version), so the easier way to get a glimpse of the big changes is to look at its releases page.
List of changes between
electron-packager@7.3.0andelectron-packager@12.2.0: electron/packager@v7.3.0...v12.2.0