8000 Making sublime-tabs ready for release · Issue #6842 · atom/atom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Making sublime-tabs ready for release #6842

Closed
ddavison opened this issue May 18, 2015 · 11 comments
Closed

Making sublime-tabs ready for release #6842

ddavison opened this issue May 18, 2015 · 11 comments
Labels
deprecation-help question

Comments

@ddavison
Copy link
Contributor

Hey guys,

I'm the author of the sublime-tabs package and I'll need some help migrating the package.

Right now, there are thousands of people using this package, and the sublime-tabs package relies on the deprecated API to this day with a total count of 29 deprecations. (ddavison/sublime-tabs#53).

@ConnorVG gave this a shot, but was unsuccessful in his attempts. I've also attempted to fix these deprecations, but I, as well as others, have failed with errors like "undefined is not a function" trying to use atom.views.getView(atom.workspace).command etc etc.

So the question...

Is there a plan to have this implemented in core? and if not, is there somebody that uses sublime-tabs, and can assist me with removing all these deprecations so sublime-tabs will still work in Atom v1?

Reference Material:
#2205
ddavison/sublime-tabs#43
atom/tree-view#3

(fyi, i'm opening this issue per the blog post stating we can open a help issue here)
@lee-dohm
Copy link
Contributor

#3683 is still marked as v1.0 roadmap, so I would say that indicates that there still is a plan to have this implemented in core ... but I'm not an Atom Core team member, so I should probably let them speak to that 😀

@benogle
Copy link
Contributor
benogle commented May 19, 2015

We can help upgrade. One of us will look at it this week. We honestly probably wont get to the non-performance, and non-deprecation related things on the roadmap before 1.0.

@ConnorVG
Copy link

@benogle 💋

@v3ss0n
Copy link
v3ss0n commented May 20, 2015

Sublime functionality indeed need to be in core. Please consider. @izuzak .

@iamstarkov
Copy link

any news? do you still need help? if so, what directions are not already taken?

@ddavison
Copy link
Contributor Author

an update - there is an individual working on getting this implemented to core, and has a PR! atom/tabs#145

@iamstarkov
Copy link

okie, thx

@winstliu
Copy link
Contributor
winstliu commented Jun 3, 2015

Hi @ddavison since atom/tabs#145 has been merged, I'm going to close this.
If you still want this open just leave a 💬!

@winstliu winstliu closed this as completed Jun 3, 2015
@ddavison
Copy link
Contributor Author
ddavison commented Jun 3, 2015

yep! i'm so glad. I am now closing all my issues in reference to that PR

@jglovier
Copy link
Contributor
jglovier commented Jun 3, 2015

dance

@lock
Copy link
lock bot commented Jan 22, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
deprecation-help question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@benogle @v3ss0n @iamstarkov @lee-dohm @jglovier @winstliu @ddavison @ConnorVG
0