8000 Flaky tests: line ending selector Status bar tile ... · Issue #17326 · atom/atom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Flaky tests: line ending selector Status bar tile ... #17326

Closed
jasonrudolph opened this issue May 15, 2018 · 2 comments
Closed

Flaky tests: line ending selector Status bar tile ... #17326

jasonrudolph opened this issue May 15, 2018 · 2 comments
Labels
flaky-test

Comments

@jasonrudolph
Copy link
Contributor

We've seen the line-ending-selector tests below fail twice in the past week:

https://circleci.com/gh/atom/atom/7475
https://circleci.com/gh/atom/atom/7499

Rebuilding can resolve the failures:

circleci

These recent failures are correlated with the recent Electron 2.0 upgrade (#17273), although we've seen these failures before (e.g., https://circleci.com/gh/atom/atom/7267).

Failures

Package tests failed for line-ending-selector:
..........FFF.

line ending selector
  Status bar tile
    clicking the tile
      when selecting a different line ending for the file
        it changes the line endings in the buffer
          timeout: timed out after 60000 msec waiting for something to happen
      when modal is exited
        it leaves the tile selection as-is
          Expected 'CRLF' to be ''.
            at jasmine.Spec.runs (/Users/distiller/atom/node_modules/line-ending-selector/spec/line-ending-selector-spec.js:24:50)
          timeout: timed out after 60000 msec waiting for something to happen
    closing the last text editor
      it displays no line ending in the status bar
        Expected 'CRLF' to be ''.
          at jasmine.Spec.runs (/Users/distiller/atom/node_modules/line-ending-selector/spec/line-ending-selector-spec.js:24:50)
        Expected '' to be 'CRLF'.
          at lineEndingTile.onDidChange (/Users/distiller/atom/node_modules/line-ending-selector/spec/line-ending-selector-spec.js:232:58)
          at Function.module.exports.Emitter.simpleDispatch (/Users/distiller/atom/node_modules/event-kit/lib/emitter.js:25:14)
          at Emitter.module.exports.Emitter.emit (/Users/distiller/atom/node_modules/event-kit/lib/emitter.js:141:28)
          at StatusBarItem.setLineEndings (/Users/distiller/atom/node_modules/line-ending-selector/lib/status-bar-item.js:15:18)
          at /Users/distiller/atom/out/app/node_modules/line-ending-selector/lib/main.js:104:21
          at Function.module.exports.Emitter.simpleDispatch (/Users/distiller/atom/node_modules/event-kit/lib/emitter.js:25:14)
          at Emitter.module.exports.Emitter.emit (/Users/distiller/atom/node_modules/event-kit/lib/emitter.js:141:28)
          at Workspace.didChangeActivePaneItemOnPaneContainer (/Users/distiller/atom/src/workspace.js:438:22)
          at WorkspaceCenter.paneContainer.onDidChangeActivePaneItem (/Users/distiller/atom/src/workspace-center.js:17:14)
          at Function.module.exports.Emitter.simpleDispatch (/Users/distiller/atom/node_modules/event-kit/lib/emitter.js:25:14)
          at Emitter.module.exports.Emitter.emit (/Users/distiller/atom/node_modules/event-kit/lib/emitter.js:141:28)
          at PaneContainer.didChangeActiveItemOnPane (/Users/distiller/atom/src/pane-container.js:281:20)
          at Pane.setActiveItem (/Users/distiller/atom/src/pane.js:440:42)
          at Pane.removeItem (/Users/distiller/atom/src/pane.js:694:14)
          at Pane.destroyItem (/Users/distiller/atom/src/pane.js:779:10)
          at Promise.all.getItems.map.item (/Users/distiller/atom/src/pane.js:787:40)
          at Array.map (<anonymous>)
          at Pane.destroyItems (/Users/distiller/atom/src/pane.js:787:23)
          at Pane.destroy (/Users/distiller/atom/src/pane.js:1024:19)
          at atom.workspace.open.then (/Users/distiller/atom/node_modules/line-ending-selector/spec/line-ending-selector-spec.js:258:44)
          at <anonymous>

Finished in 121.406 seconds
14 tests, 70 assertions, 5 failures, 0 skipped
@jasonrudolph
Copy link
Contributor Author

Observed again in https://circleci.com/gh/atom/atom/7532

jasonrudolph added a commit to atom/line-ending-selector that referenced this issue May 17, 2018
@jasonrudolph
Set up change observer _before_ performing change
3db501b 
Prior to this change, the test changed 
8000
the line ending for a file,
_then_ registered a change observer, and then waited for the change
observer to be called. We're seeing some flakiness with this test
(atom/atom#17326), and I think this order of
operations might be the cause of the flakiness.

To make sure we observer gets called when the line endings change, let's
register the observer _before_ changing the line endings.
@jasonrudolph jasonrudolph mentioned this issue May 17, 2018
Merged
jasonrudolph added a commit that referenced this issue May 18, 2018
@jasonrudolph
⬆️ line-ending-selector@0.7.7
bf3c213 
Fixes #17326 (hopefully 🤞)
jasonrudolph added a commit that referenced this issue May 18, 2018
@jasonrudolph
⬆️ line-ending-selector@0.7.7
2b9269a 
Fixes #17326 (hopefully 🤞)
@lock
Copy link
lock bot commented Nov 14, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Nov 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flaky-test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasonrudolph
0