8000 Pass drop_null_geometries through by nikolai-b · Pull Request #45 · ateucher/rmapshaper · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Pass drop_null_geometries through #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2016
Merged

Pass drop_null_geometries through #45

merged 1 commit into from
Sep 7, 2016

Conversation

nikolai-b
Copy link
Contributor

Following on from #43 (comment) I think that drop_null_geometries should be passed though or at least have some information somewhere explaining that it is always FALSE for geo_lists

@ateucher ateucher merged commit 2950c6b into ateucher:master Sep 7, 2016
@ateucher
Copy link
Owner
ateucher commented Sep 7, 2016

Thanks! You're right, it should pass it through, good catch. I'll just fix the failing test.

@ateucher
Copy link
Owner
ateucher commented Sep 8, 2016

All good. Thanks @nikolai-b!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikolai-b @ateucher
0