8000 get with prefix by texnicii · Pull Request #14 · aternosorg/php-etcd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

get with prefix #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

get with prefix #14

wants to merge 2 commits into from

Conversation

texnicii
Copy link
@texnicii texnicii commented Apr 8, 2025 •
edited
Loading

Added request with prefix which returns Generator<Mvccpb\KeyValue>

// example 
foreach ($client->getWithPrefix('/some-namespace') as $val) {
    echo $val->getKey() . " -> " . $val->getValue() . "\n";
}

@CLAassistant
Copy link
CLAassistant commented Apr 8, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@texnicii texnicii mentioned this pull request Apr 8, 2025
Open
matthi4s
matthi4s requested changes Apr 10, 2025
View reviewed changes
Copy link
Member
@matthi4s matthi4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! You haven't updated the ShardedClient yet, but with the changed ClientInterface, that would cause fatal errors. You probably have to request all keys from all clients for the ShardedClient.

@texnicii texnicii requested a review from matthi4s April 18, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthi4s matthi4s Awaiting requested review from matthi4s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@texnicii @CLAassistant @matthi4s
0