perf: increase default assertion solving timeout from 1s to 1m #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b82b7e6 to
a9f3d11
Compare
0xkarmacoma
approved these changes
Sep 23, 2024
|
fyi, the 1m limit was chosen based on the solving time needed for those tests in our ci, on M1 pro. i agree with your concern, but i think even 10s might feel getting stuck especially when there are many paths, unless proper communication of progress is provided. a better approach to mitigate would be to provide clearer progress updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current default timeout for assertion solving is 1s, which is too short for most cases. as a result, many users disable the timeout altogether. this pr updates the default timeout to a more reasonable value, allowing most tests to be solved within the default time limit.