8000 🔨 Add Missing Error Code in `parse_build_out` Warning by pcaversaccio · Pull Request #300 · a16z/halmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🔨 Add Missing Error Code in parse_build_out Warning #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 1, 2024
Merged

🔨 Add Missing Error Code in parse_build_out Warning #300

merged 4 commits into from
Jun 1, 2024

Conversation

pcaversaccio
Copy link
Contributor

Patching a refactor regression from #298.

@pcaversaccio pcaversaccio changed the title 🔨 Add Missing Error Code in parse_build_out 🔨 Add Missing Error Code in parse_build_out Warning Jun 1, 2024
@0xkarmacoma 0xkarmacoma self-requested a review June 1, 2024 18:37
pcaversaccio and others added 3 commits June 1, 2024 20:45
@pcaversaccio
💄 Prettify
84e580e 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@0xkarmacoma
warnings: rename warn() to warn_code()
27c781b 
name conflict was bad all along
@0xkarmacoma
utils: simplify color funcs
2040b07
0xkarmacoma
0xkarmacoma approved these changes Jun 1, 2024
View reviewed changes
Copy link
Collaborator
@0xkarmacoma 0xkarmacoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing, and sorry I didn't catch it in testing 🙈

@0xkarmacoma 0xkarmacoma merged commit f7216ee into a16z:main Jun 1, 2024
52 checks passed
@pcaversaccio pcaversaccio deleted the fix/patch-warning branch June 2, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xkarmacoma 0xkarmacoma 0xkarmacoma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcaversaccio @0xkarmacoma
0