add intermediary halmos-builder image and dockerize more workflows #308
Conversation
|
note: we may eventually want to have a |
trying to avoid `Error: Process completed with exit code 139.`
| - name: Install Vyper | ||
| if: ${{ matrix.project.dir == 'snekmate' }} | ||
| run: | | ||
| docker run --name halmos-vyper --entrypoint uv halmos-image pip install vyper | ||
| docker commit --change 'ENTRYPOINT ["halmos"]' halmos-vyper halmos-image |
There was a problem hiding this comment.
shows that we can layer vyper on top of the existing halmos image fairly easily in github workflows
| @@ -22,43 +24,59 @@ jobs: | |||
| project: | |||
| - repo: "morpho-org/morpho-data-structures" | |||
| dir: "morpho-data-structures" | |||
| cmd: "halmos --function testProve --loop 4 --symbolic-storage" | |||
| cmd: "--function testProve --loop 4 --symbolic-storage" | |||
There was a problem hiding this comment.
is the yices solver not used here due to the weird failure you mentioned?
.github/workflows/test-external.yml
Outdated
| sudo mv yices-2.6.4/include/* /usr/local/include/ | ||
| rm -rf yices-2.6.4 | ||
| - name: Print halmos version | ||
| run: docker run -v .:/workspace halmos-image --version |
There was a problem hiding this comment.
i tried to print the halmos version to double check the correct halmos version is running, but the version printed here is quite different from what we get locally.
Run docker run -v .:/workspace halmos-image --version
halmos 0.1.dev1+g81b7ae5
https://github.com/a16z/halmos/actions/runs/10014074545/job/27683005509
in my local machine, the version is:
(.venv) DParkMBP14:halmos dpark$ halmos --version
halmos 0.1.12.dev9+g3f5d10c
can we improve the dockerfile to contain the consistent halmos version?
There was a problem hiding this comment.
the only difference I can see is that we install halmos via uv pip install in the Dockerfile instead of pip install
There was a problem hiding this comment.
oh and actually the other big difference is the sparse checkout we do in github actions, which explains the 0.1.dev1 part. I think it's fine, the git hash has the information we need really
Note: during CI builds, we only perform a sparse checkout so we expect the printed version to be slightly wonky, e.g. `halmos 0.1.dev1+g81b7ae5` (base tag is wrong, number of commits ahead is wrong, but git hash is correct) For released images, we expect the version string to be correct (e.g. `halmos 0.1.14`)
halmos-builder:
solvershalmos:
halmos-builder, just does auv pip installof a halmos checkoutFor test-long and test-ffi, we:
halmosimage based on thathalmoscontainer