8000 dep: unpin z3 version (cont'd) by daejunpark · Pull Request #276 · a16z/halmos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

dep: unpin z3 version (cont'd) #276

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 18, 2024
Merged

dep: unpin z3 version (cont'd) #276

merged 3 commits into from
Apr 18, 2024

Conversation

daejunpark
Copy link
Collaborator
@daejunpark daejunpark commented Apr 17, 2024 •
edited
Loading

unpin z3 version, with no minimum version requirement

for future reference:

  • disable ci caches + pin z3-solver==4.12.2.0 #235 pinned z3 to 4.12.2 because at that time, pip install z3 4.12.3 didn't utilize the installation cache (it cached the package download but not the installation).
  • it seems that the issue has been fixed in a later z3 version, and unpin z3 version #275 attempted to unpin z3 and require the version >= 4.13 (the latest version)
  • however, since version 4.13 turned out to significantly underperforms for nonlinear queries, even with int-blasting enabled, this pr removes the minimum version requirement, and specifies a particular version for long-running ci tests.

@daejunpark daejunpark requested a review from 0xkarmacoma April 17, 2024 20:32
@daejunpark daejunpark changed the title dep: require z3 >= 4.13 dep: unpin z3 version (cont'd) Apr 18, 2024
0xkarmacoma
0xkarmacoma approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator
@0xkarmacoma 0xkarmacoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will follow up with the removal of requirements.txt 👍

@daejunpark daejunpark merged commit abe353d into main Apr 18, 2024
50 checks passed
@daejunpark daejunpark deleted the z3-4.13 branch April 18, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xkarmacoma 0xkarmacoma 0xkarmacoma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daejunpark @0xkarmacoma
0