8000 Use JSON member iterator instead of rescanning by Smjert · Pull Request #8122 · osquery/osquery · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JSON member iterator instead of rescanning #8122

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Use JSON member iterator instead of rescanning #8122

merged 1 commit into from
Aug 30, 2023

Conversation

Smjert
Copy link
Member
@Smjert Smjert commented Aug 29, 2023

A minor improvement I missed in the review, to avoid repetition and rescanning the JSON member we've already found.

@Smjert Smjert requested review from a team as code owners August 29, 2023 18:01
sharvilshah
sharvilshah approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member
@sharvilshah sharvilshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for catching this @Smjert

@sharvilshah sharvilshah added this to the 5.10.0 milestone Aug 30, 2023
@Smjert Smjert merged commit b8d2489 into osquery:master Aug 30, 2023
sharvilshah added a commit to sharvilshah/osquery that referenced this pull request Oct 18, 2023
@sharvilshah
Revert "Use JSON member iterator instead of rescanning (osquery#8122)"
5ca8338 
This reverts commit b8d2489.
@sharvilshah sharvilshah mentioned this pull request Oct 18, 2023
Closed
@Smjert Smjert deleted the stefano/improvement/avoid-json-member-rescan branch November 14, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharvilshah sharvilshah sharvilshah approved these changes

Assignees
No one assigned
Labels
macOS performance
Projects
None yet
Milestone
5.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Smjert @sharvilshah
0