Use epoch and counter for events-based queries #7051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandrogario
approved these changes
Apr 12, 2021
aikuchin
pushed a commit
to aikuchin/osquery
that referenced
this pull request
Jul 11, 2023
…0 to master * commit '296db8039bcb40e94ef8c5b07497da5132af565c': (35 commits) 4.8.0 changelog (osquery#7057) Handle events optimization edge cases (osquery#7060) Add Shortcuts table for Windows (osquery#6994) Refactor watcher out of singleton pattern (osquery#7042) Fix optimization for multiple queries using the same subscriber (osquery#7055) Small events subscriber refactor to increase test coverage (osquery#7050) Use epoch and counter for events-based queries (osquery#7051) Guard node key to prevent duplicate enrollments (osquery#7052) Fix tls_enroll_max_attempts flag name in the documentation (osquery#7049) Improve docs on FIM, mention NTFS and Audit, etc. (osquery#7036) Change windows calculation for `physical_memory` (osquery#7028) Add an option to enable incremental linking on Windows (osquery#7044) config: Add docs for the events top-level-key (osquery#7040) Add funding link on GitHub page (osquery#7043) Update to `chrome_extensions` to not error on uncommon cases (osquery#7032) seccomp_events table in osquery (osquery#7006) Free using WTSFreeMemoryEx for WTSEnumerateSessionsExW (osquery#7039) Correct the example in the windows_events table spec (osquery#7035) Remove Buck leftovers for old versions of OpenSSL (osquery#7034) Update docs about OpenSSL and TLS behavior (osquery#7033) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that "event based" queries do not include
epochorcountertracking in their logging. These are queries in the schedule against an events table likeSELECT * FROM file_events;.I tracked this down to some optimization path in the scheduler. I think our expectation is to include these.