8000 Fix tables spec files to specify `linux` and not `posix` by zhumo · Pull Request #7644 · osquery/osquery · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tables spec files to specify linux and not posix #7644

Merged
merged 5 commits into from
Jun 24, 2022
Merged

Fix tables spec files to specify linux and not posix #7644

merged 5 commits into from
Jun 24, 2022

Conversation

zhumo
Copy link
Contributor
@zhumo zhumo commented Jun 23, 2022 •
edited
Loading

Background

A variety of tables are marked as posix, but they should be in linux:

  • lxd_certificates
  • lxd_cluster
  • lxd_cluster_members
  • lxd_images
  • lxd_instance_config
  • lxd_instance_devices
  • lxd_instances
  • lxd_networks
  • lxd_storage_pools
  • process_open_pipes

This is causing the documentation to mark these tables as workable on Mac. But when a user goes to run a query against these tables, it will give a no table error.

This PR moves these tables into the linux-only folder.

Note: The process_open_pipes.cpp has always been in linux folder, the specs were just misplaced in posix. LXD was all misplaced.

@zhumo zhumo requested review from a team as code owners June 23, 2022 17:01
@linux-foundation-easycla
Copy link
linux-foundation-easycla bot commented Jun 23, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@zhumo zhumo changed the title Move lxd table files from posix to linux Move various table files from posix to linux Jun 23, 2022
@zhumo zhumo mentioned this pull request Jun 23, 2022
Closed
@directionless directionless changed the title Move various table files from posix to linux Fix tables spec files to specify linux and not posix Jun 24, 2022
@directionless directionless merged commit 4f39a27 into osquery:master Jun 24, 2022
@noahtalerman noahtalerman mentioned this pull request Jul 8, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhumo @directionless
0