8000 CHANGELOG 5.3.0 by Smjert · Pull Request #7575 · osquery/osquery · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGELOG 5.3.0 #7575

Merged
merged 1 commit into from
May 28, 2022
Merged

CHANGELOG 5.3.0 #7575

merged 1 commit into from
May 28, 2022

Conversation

Smjert
Copy link
Member
@Smjert Smjert commented Apr 27, 2022

No description provided.

@mike-myers-tob mike-myers-tob added this to the 5.3.0 milestone Apr 27, 2022
@directionless
Copy link
Member

FWIW I have tooling that generates these.

@Smjert Smjert force-pushed the stefano/release/changelog-5.3.0 branch from 7cb832b to ec12e4a Compare May 2, 2022 13:41
@Smjert
Copy link
Member Author
Smjert commented May 2, 2022 •
edited
Loading

FWIW I have tooling that generates these.

Ah yeah I went by hand, it's not too difficult, the categorization has to be done by hand anyway.
What I have done is:

git log --oneline 5.2.3..HEAD

This gives an output like:

[...]
4ea9f2c73 Fix for gathering python packages from any user Python installations (#7414)
7bb36e889 Implement `output_size` for `osquery_schedule` (#7436)
fd529718e CHANGELOG 5.2.2 (#7447)
d0db86439 Bump mkdocs from 1.1.2 to 1.2.3 in /docs (#7457)

And from there, cleanup + categorization.

Finally for the number of contributors:

git shortlog --summary --numbered --email 5.2.3..HEAD

which results in:

     5  Alessandro Gario <5714290+alessandrogario@users.noreply.github.com>
     3  Jason Meller <jason@kolide.co>
     2  Joe Sweeney <joe.sweeney@trailofbits.com>
     1  Joe Sweeney <joseph.sweeney95@gmail.com>
     1  Mayur Shingote <mayur.shingote@yahoo.com>
     1  Nick Collier <48997416+nickcollier@users.noreply.github.com>
     1  Rajesh Pangare <44482451+raj3shp@users.noreply.github.com>
     6  Sharvil Shah <sharvil@sharvilshah.com>
    28  Stefano Bonicatti <stefano.bonicatti@gmail.com>
     1  dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
     6  iko1 <me@remotecpp.dev>
     1  np5 <eric@zentral.pro>
     3  seph <seph@directionless.org>
     1  yonnym <yonnym@gmail.com>
     1  zhupeijun <zhupeijun2009@gmail.com>

And removing the bot, plus a duplicate (same person, different mail) we get the result of 13 contributors.

@Smjert Smjert force-pushed the stefano/release/changelog-5.3.0 branch from ec12e4a to 0d1a9d6 Compare May 11, 2022 21:23
@Smjert Smjert force-pushed the stefano/release/changelog-5.3.0 branch from 0d1a9d6 to 1a84617 Compare May 25, 2022 13:03
@Smjert Smjert marked this pull request as ready for review May 25, 2022 13:22
@Smjert Smjert requested review from a team as code owners May 25, 2022 13:22
zwass
zwass approved these changes May 26, 2022
View reviewed changes
Copy link
Member
@zwass zwass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@directionless
Copy link
Member

FWIW I have tooling that generates these.

Ah yeah I went by hand, it's not too difficult, the categorization has to be done by hand anyway. What I have done is:

Yeah, in many ways it's a glorified git log --oneline, but it adds several features.

  • it aggregates non-squashed PRs. They happen sometimes, and having tooling helped.
  • it replace the github links of #7575 with fill URLs, like https://github.com/osquery/osquery/pull/7575
  • it supports rerunning to find any missed commits. (It keys this off the PR number)

Doing it manually isn't wrong, the results look fine. But so you know.

Anyhow, Zach approved this PR 👍

@Smjert Smjert merged commit 8fb3bb3 into osquery:master May 28, 2022
@Smjert Smjert deleted the stefano/release/changelog-5.3.0 branch May 28, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwass zwass zwass approved these changes

Assignees
No one assigned
Labels
documentation release
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Smjert @directionless @zwass @mike-myers-tob
0