8000 Fix third party libraries flags leaking to osquery targets by Smjert · Pull Request #7480 · osquery/osquery · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix third party libraries flags leaking to osquery targets #7480

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Fix third party libraries flags leaking to osquery targets #7480

merged 1 commit into from
Feb 16, 2022

Conversation

Smjert
Copy link
Member
@Smjert Smjert commented Feb 16, 2022

RocksDB was incorrectly linking to the thirdparty_cxx_settings target
publicly, leaking its flags (and specifically the one disabling warnings)
to some osquery targets.

Also remove redudant linking of c_settings and cxx_settings in
dbus/expat

@Smjert
Fix third party libraries flags leaking to osquery targets
837db0e 
RocksDB was incorrectly linking to the thirdparty_cxx_settings target
publicly, leaking its flags (and specifically the one disabling warnings)
to some osquery targets.

Also remove redudant linking of c_settings and cxx_settings in
dbus/expat
@Smjert Smjert added build cmake pure cmake changes labels Feb 16, 2022
@Smjert Smjert requested review from a team as code owners February 16, 2022 15:31
@Smjert Smjert added the libraries For things referring to osquery third party libraries label Feb 16, 2022
@Smjert Smjert merged commit 4def296 into osquery:master Feb 16, 2022
@Smjert Smjert deleted the stefano/build/thirdpartyflags-leaking branch February 16, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
build cmake pure cmake changes libraries For things referring to osquery third party libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Smjert @directionless
0