8000 Implement `output_size` for `osquery_schedule` by sharvilshah · Pull Request #7436 · osquery/osquery · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement output_size for osquery_schedule #7436

Merged
merged 12 commits into from
Feb 15, 2022
Merged

Implement output_size for osquery_schedule #7436

merged 12 commits into from
Feb 15, 2022

Conversation

sharvilshah
Copy link
Member

Addresses #7147

This PR implements a simple output_size column for scheduled queries, while being aware of the newer typed RowData.

Continuation of #7377

@sharvilshah sharvilshah requested review from a team as code owners January 7, 2022 18:16
@sharvilshah sharvilshah mentioned this pull request Jan 7, 2022
Closed
Smjert
Smjert previously approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member
@Smjert Smjert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for moving forward with this!
Only a minor nit ;)

osquery/sql/sqlite_util.cpp Outdated Show resolved Hide resolved
directionless
directionless reviewed Jan 12, 2022
View reviewed changes
Copy link
Member
@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm excited to see this

osquery/core/sql/query_performance.h Show resolved Hide resolved
specs/utility/osquery_schedule.table Show resolved Hide resolved
@sharvilshah @Smjert
Update osquery/sql/sqlite_util.cpp
193ff9e 
Co-authored-by: Stefano Bonicatti <smjert@gmail.com>
@sharvilshah
Copy link
Member Author

I think this is good to go and requires a final review. Can we also add this to the next milestone?

@directionless directionless added this to the 5.3.0 milestone Jan 18, 2022
@sharvilshah sharvilshah merged commit 7bb36e8 into osquery:master Feb 15, 2022
@sharvilshah sharvilshah deleted the output-size branch February 15, 2022 18:57
@zwass zwass mentioned this pull request May 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless left review comments

5384 @Smjert Smjert Smjert approved these changes

Assignees
No one assigned
Labels
virtual tables
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sharvilshah @Smjert @directionless @mike-myers-tob
0