8000 CMake: Future proof Python finding mechanism by Smjert · Pull Request #6120 · osquery/osquery · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Future proof Python finding mechanism #6120

Merged
merged 1 commit into from
Dec 12, 2019
Merged

CMake: Future proof Python finding mechanism #6120

merged 1 commit into from
Dec 12, 2019

Conversation

Smjert
Copy link
Member
@Smjert Smjert commented Dec 11, 2019

CMake 3.16 doesn't set Python3_EXECUTABLE as cache variable anymore,
it has changed to _Python3_EXECUTABLE which is for internal use.
The module returns Python3_EXECUTABLE as a local variable,
so we share that value through a new custom cache variable,
OSQUERY_PYTHON_EXECUTABLE.

@Smjert
CMake: Future proof Python finding mechanism
98dfb00 
CMake 3.16 doesn't set Python3_EXECUTABLE as cache variable anymore,
it has changed to _Python3_EXECUTABLE which is for internal use.
The module returns Python3_EXECUTABLE as a local variable,
so we share that value through a new custom cache variable,
OSQUERY_PYTHON_EXECUTABLE.
@Smjert Smjert added cmake pure cmake changes CI/CD Anything about the Continuous Integration or Continuous Deployment tool used by the repository labels Dec 11, 2019
@theopolis theopolis merged commit 668a1d8 into osquery:master Dec 12, 2019
@Smjert Smjert deleted the stefano/ci/python-select branch December 19, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theopolis theopolis theopolis approved these changes

Assignees
No one assigned
Labels
CI/CD Anything about the Continuous Integration or Continuous Deployment tool used by the repository cmake pure cmake changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Smjert @theopolis
0