8000 Explicitly set the MSVC runtime library by Smjert · Pull Request #6818 · osquery/osquery · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly set the MSVC runtime library #6818

Merged
merged 1 commit into from
Dec 19, 2020
Merged

Explicitly set the MSVC runtime library #6818

merged 1 commit into from
Dec 19, 2020

Conversation

Smjert
Copy link
Member
@Smjert Smjert commented Dec 19, 2020 •
edited
Loading

CMake doesn't add the /MD flag in the CMAKE_<LANG>_FLAGS_<CONFIG>
anymore, to be then replaced with /MT by us.
Without it, the build still defaults to using /MD, which is wrong.

@Smjert
Explicitly set the MSVC runtime library
8687ef6 
CMake doesn't add the /MD flag in the CMAKE_<LANG>_FLAGS_<CONFIG>
anymore, to be then replaced with /MT by us.
Without it, the build still defaults to using /MD, which is wrong.
@Smjert Smjert added build cmake pure cmake changes labels Dec 19, 2020
@theopolis theopolis closed this Dec 19, 2020
@theopolis theopolis reopened this Dec 19, 2020
@theopolis theopolis merged commit 90c981a into osquery:master Dec 19, 2020
@mike-myers-tob mike-myers-tob mentioned this pull request Dec 21, 2020
Closed
@directionless directionless mentioned this pull request Dec 22, 2020
Open
@Smjert Smjert deleted the stefano/build/msvc-runtime-library branch January 13, 2021 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
build cmake pure cmake changes Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Smjert @directionless @theopolis
0