8000 cpack: Use CPACK_RPM_PACKAGE_RELEASE by theopolis · Pull Request #6805 · osquery/osquery · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpack: Use CPACK_RPM_PACKAGE_RELEASE #6805

Merged
merged 1 commit into from
Dec 14, 2020
Merged

cpack: Use CPACK_RPM_PACKAGE_RELEASE #6805

merged 1 commit into from
Dec 14, 2020

Conversation

theopolis
Copy link
Member

According to https://cmake.org/cmake/help/latest/cpack_gen/rpm.html we should be setting CPACK_RPM_PACKAGE_RELEASE instead of CPACK_RPM_PACKAGE_RELEASE_DIST.

@theopolis
Copy link
Member Author

You can see the generated RPM artifact is now: osquery-4.5.1_61_ge30bae44-1.linux.x86_64.rpm

Smjert
Smjert approved these changes Dec 13, 2020
View reviewed changes
Copy link
Member
@Smjert Smjert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@theopolis
Copy link
Member Author

With this, my major concerns with #6772 are mitigated. I'd like to try to use the CI-built packages for the next release too.

@theopolis theopolis merged commit dcfbd89 into osquery:master Dec 14, 2020
aikuchin pushed a commit to aikuchin/osquery that referenced this pull request Jul 11, 2023
@lexuxor
Merge pull request osquery#14 in CLOUD/osquery from sync/osquery-4.6.…
1fa4329 
…0 to master

* commit '2685844e7a4b1dbddd786f0ab3c1d26656deff28': (62 commits)
  CHANGELOG 4.6.0 (osquery#6809)
  Merge pull request from GHSA-4g56-2482-x7q8
  cpack: Use CPACK_RPM_PACKAGE_RELEASE (osquery#6805)
  CMake: add max version limit to 3.18.0 on Linux (osquery#6801)
  libs: Update sqlite to version 3.34.0 (osquery#6804)
  Add indexed column support to Windows users table (osquery#6782)
  file_events: Add configuration flag (osquery#6663)
  CI: Make the built packages available to be downloaded (osquery#6772)
  Remove a Buck leftover (osquery#6799)
  CI: Update brew scripts (osquery#6794)
  CI: Python installation improvements on Windows (osquery#6764)
  BPF: Fix the tests (osquery#6783)
  libs: Update bzip2 to version 1.0.8 (osquery#6786)
  Update cmake_minum_required to 3.17.5 and pin version in CI (osquery#6770)
  CMake: Remove unused LTCG flag (osquery#6769)
  Remove boost workaround introduced in osquery#5591 for string_view (osquery#6771)
  libs: Update BPF libraries to support LLVM 11 (osquery#6775)
  BPF: Fix wrong d_type compare in fs classes (osquery#6774)
  startup_info: Fix memory leak in the dbus classes (osquery#6773)
  Change urls for submodules gpg-error, libgcrypt, libcap (osquery#6768)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smjert Smjert Smjert approved these changes

Assignees
No one assigned
Labels
Linux packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theopolis @Smjert
0