libraries: Move ssdeep-cpp to source_migration #6464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smjert
requested changes
May 28, 2020
There was a problem hiding this comment.
@theopolis Looks good! Just a couple of minor things to look at :).
| HAVE_CONFIG_H | ||
| ) | ||
|
|
||
| target_link_libraries(thirdparty_ssdeep-cpp PRIVATE | ||
| target_link_libraries(thirdparty_ssdeep-cpp_cpp PRIVATE | ||
| thirdparty_cxx_settings | ||
| thirdparty_c_settings |
There was a problem hiding this comment.
thirdparty_c_settings should be removed from here
| if(DEFINED PLATFORM_LINUX) | ||
| target_include_directories(thirdparty_ssdeep-cpp_cpp PRIVATE | ||
| "${CMAKE_CURRENT_SOURCE_DIR}/config/linux" | ||
| "${library_root}" |
There was a problem hiding this comment.
Nitpick: maybe dedup "${library_root}" for both macOS and Linux with:
target_include_directories(thirdparty_ssdeep-cpp_cpp PRIVATE
"${library_root}"
)
target_include_directories(thirdparty_ssdeep-cpp_c PRIVATE
"${library_root}"
)
outside of the if statements, since it's common for both?
6 tasks
Smjert
approved these changes
May 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
ssdeep-cppto source migration (for macOS).