8000 tests: Add sanity test for nvram by willnewton · Pull Request #5903 · osquery/osquery · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Add sanity test for nvram #5903

Merged
merged 1 commit into from
Oct 21, 2019
Merged

tests: Add sanity test for nvram #5903

merged 1 commit into from
Oct 21, 2019

Conversation

willnewton
Copy link
Contributor

Add a simple sanity test for macOS nvram.

Closes: #5019

directionless
directionless previously approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member
@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@directionless
Copy link
Member

That's a linting failure.

@theopolis
Copy link
Member

If you rebase onto master then run make format_check it will show any formatting requirements.

@willnewton
tests: Add sanity test for nvram
ed0698b 
Add a simple sanity test for macOS nvram.

Closes: osquery#5019
@willnewton
Copy link
Contributor Author

If you rebase onto master then run make format_check it will show any formatting requirements.

Thanks, I've rebased on master with the formatting fixed.

@directionless directionless merged commit df86635 into osquery:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
Hacktoberfest test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create tests for the table nvram
3 participants
@willnewton @directionless @theopolis
0