Abstracting services #183
Merged
Abstracting services #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #183 +/- ##
==========================================
- Coverage 76.39% 74.14% -2.26%
==========================================
Files 19 23 +4
Lines 538 553 +15
==========================================
- Hits 411 410 -1
- Misses 127 143 +16 ☔ View full report in Codecov by Sentry. |
git-elliot
approved these changes
Feb 22, 2024
git-elliot
approved these changes
Feb 22, 2024
Merged
git-elliot
reviewed
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made services singleton to not use static everywhere and to support instances for the flutter overrides.
Also removed the use of injection and getit packages.
Changed class names:
HostScanner --> HostScannerService
PortScanner --> PortScannerService
Usage example
Old:
HostScanner.x();ARPService.x();PortScanner.x();New:
HostScannerService.instance.x();ARPService.instance.x();PortScannerService.instance.x();Fix: osociety/network_tools_flutter#38
This pr does not change the package logic.