8000 chore: mark internal server errors caused by misconfiguration as such by zepatrik · Pull Request #3248 · ory/kratos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: mark internal server errors caused by misconfiguration as such #3248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore: mark internal server errors caused by misconfiguration as such #3248

wants to merge 1 commit into from

Conversation

zepatrik
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link
codecov bot commented Apr 21, 2023

Codecov Report

Merging #3248 (e946a04) into master (7f232bf) will decrease coverage by 0.03%.
The diff coverage is 75.00%.

❗ Current head e946a04 differs from pull request most recent head 52d7c45. Consider uploading reports for the commit 52d7c45 to get more accurate results

@@            Coverage Diff             @@
##           master    #3248      +/-   ##
==========================================
- Coverage   77.93%   77.90%   -0.03%     
==========================================
  Files         324      320       -4     
  Lines       20732    20443     -289     
==========================================
- Hits        16158    15927     -231     
+ Misses       3365     3319      -46     
+ Partials     1209     1197      -12
Impacted Files Coverage Δ
courier/sms.go 60.37% <0.00%> (ø)
selfservice/strategy/oidc/provider_auth0.go 72.30% <0.00%> (ø)
selfservice/strategy/oidc/provider_dingtalk.go 31.52% <0.00%> (ø)
selfservice/strategy/oidc/provider_gitlab.go 81.81% <0.00%> (ø)
selfservice/strategy/oidc/provider_linkedin.go 64.47% <0.00%> (ø)
selfservice/strategy/oidc/provider_microsoft.go 60.00% <0.00%> (ø)
selfservice/strategy/oidc/strategy.go 63.71% <0.00%> (+2.48%) ⬆️
selfservice/strategy/oidc/strategy_registration.go 65.08% <0.00%> (-2.36%) ⬇️
selfservice/strategy/oidc/strategy_settings.go 63.09% <0.00%> (ø)
selfservice/strategy/webauthn/login.go 62.50% <0.00%> (ø)
... and 32 more

... and 16 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr mentioned this pull request Apr 28, 2025
Open
7 tasks
@aeneasr
Copy link
Member
aeneasr commented Apr 28, 2025

This would be nice to do! If you have some donwtime @zepatrik maybe finish this up? I will move the config error to herodot in the meanwhile.

@aeneasr
Copy link
Member
aeneasr commented Apr 28, 2025

ory/herodot#135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr will be requested when the pull request is marked ready for review aeneasr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zepatrik @aeneasr
2A3B
0