8000 feat: added Econt as OIDC Provider by peturgeorgievv · Pull Request #3058 · ory/kratos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: added Econt as OIDC Provider #3058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: added Econt as OIDC Provider #3058

wants to merge 2 commits into from

Conversation

peturgeorgievv
Copy link
@peturgeorgievv peturgeorgievv commented Jan 30, 2023 •
edited
Loading

This PR is intending to implement another OIDC provider for Econt a Bulgarian common provider to Kratos since Econt has non-standard paths to its auth and token endpoints.

Related issue(s)

There is no issue as this is just a new OIDC provider.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

I added econt as OIDC Provider, as we already have it implemented in our project and it would be good to not have a kratos-fork for it.

@CLAassistant
Copy link
CLAassistant commented Jan 30, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 30, 2023
View reviewed changes
@codecov
Copy link
codecov bot commented Jan 30, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 104 lines in your changes missing coverage. Please review.

Project coverage is 76.87%. Comparing base (44556a4) to head (7ebb0ca).
Report is 1036 commits behind head on master.

Files with missing lines Patch % Lines
selfservice/strategy/oidc/provider_econt.go 0.00% 102 Missing ⚠️
selfservice/strategy/oidc/provider_config.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3058      +/-   ##
==========================================
- Coverage   77.28%   76.87%   -0.41%     
==========================================
  Files         313      314       +1     
  Lines       19552    19656     +104     
==========================================
  Hits        15110    15110              
- Misses       3274     3378     +104     
  Partials     1168     1168

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

@zepatrik zepatrik Awaiting requested review from zepatrik

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peturgeorgievv @CLAassistant
0