8000 feat: add LoginStarted and RegistrationStarted events by gaultier · Pull Request #4404 · ory/kratos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add LoginStarted and RegistrationStarted events #4404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 7, 2025
Merged

feat: add LoginStarted and RegistrationStarted events #4404

merged 6 commits into from
May 7, 2025

Conversation

gaultier
Copy link
Contributor
@gaultier gaultier commented May 6, 2025 •
edited
Loading

Changes:

  • Add LoginStarted and RegistrationStarted events along their required attributes
  • Sort all event attributes alphabetically
  • Emit these events when a new login/registration flow is created, after basic validation passed
  • It is unclear yet how many of these events will be emitted, as such it is suggested that in a first phase, they remain internal and are not yet sent externally to avoid surprises (note: sometimes, these events can be emitted without user action such as simply visiting/being redirected to the sign-in page, etc)

Documentation PR: ory/docs#2144

Issue: https://github.com/ory-corp/cloud/issues/7895

Examples in Grafana:

  • LoginStarted: Screenshot 2025-05-06 at 14 54 32
  • RegistrationStarted: Screenshot 2025-05-06 at 14 46 17

@gaultier gaultier requested review from aeneasr and a team as code owners May 6, 2025 13:18
@gaultier gaultier mentioned this pull request May 6, 2025
Merged
6 tasks
aeneasr
aeneasr reviewed May 6, 2025
View reviewed changes
@gaultier gaultier force-pushed the pgaultier-feat-add-event-login-attempt branch from f826b73 to 0bcf1c5 Compare May 6, 2025 14:13
@gaultier gaultier force-pushed the pgaultier-feat-add-event-login-attempt branch from 9b24fdb to 1b39ddd Compare May 6, 2025 14:32
@codecov Codecov
Copy link
codecov bot commented May 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 12.50000% with 28 lines in your changes missing coverage. Please review.

Project coverage is 50.13%. Comparing base (cc014ee) to head (4f8b8fd).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
x/events/events.go 0.00% 28 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4404      +/-   ##
==========================================
- Coverage   50.16%   50.13%   -0.04%     
==========================================
  Files         370      370              
  Lines       27517    27569      +52     
==========================================
+ Hits        13805    13822      +17     
- Misses      12089    12122      +33     
- Partials     1623     1625       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gaultier gaultier enabled auto-merge (squash) May 7, 2025 10:08
@gaultier gaultier merged commit 7032fec into master May 7, 2025
28 of 29 checks passed
@gaultier gaultier deleted the pgaultier-feat-add-event-login-attempt branch May 7, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr left review comments

@alnr alnr alnr approved these changes

Assignees

@gaultier gaultier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaultier @aeneasr @alnr
0