8000 feat: add id_token support for Microsoft oidc provider. by jwmay2012 · Pull Request #4040 · ory/kratos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add id_token support for Microsoft oidc provider. #4040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: add id_token support for Microsoft oidc provider. #4040

wants to merge 5 commits into from
+121 −0

Conversation

jwmay2012
Copy link
Contributor

Support id_token verification for Microsoft oidc provider. Similar to existing support in the Go 8000 ogle and Apple providers.

Related issue(s)

https://github.com/ory/kratos/pull/3515/files

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jwmay2012 jwmay2012 changed the title Add id_token support for Microsoft oidc provider. feat: add id_token support for Microsoft oidc provider. Aug 20, 2024
@jwmay2012
Copy link
Contributor Author
jwmay2012 commented Sep 19, 2024 •
edited
Loading

We're using this code (along with a change to disable id_token nonce checking) to enable our mobile app to authenticate with kratos and Microsoft Entra ID. Running in prod.
Code and tests are mostly modified from previous id_token support PR for apple and google.

Anything needed to get this merged?

@jwmay2012 jwmay2012 requested a review from a team as a code owner January 16, 2025 15:22
@noells
Copy link
noells commented May 8, 2025

hey @jwmay2012 I'm trying your changes on my own fork because I've ran into the very same issue but I'm getting a 500 error from Kratos due to id_token verification. Could you share how you avoided the issue? 🙏🏽

{
  "error": {
    "code": 500,
    "status": "Internal Server Error",
    "request": "effe1d91-0701-97ee-b8f6-99fc96c27988",
    "reason": "Could not verify id_token",
    "message": "oidc: id token issued by a different provider, expected \"https://login.microsoftonline.com/common/v2.0\" got \"https://login.microsoftonline.com/AN_ID_WHICH_IS_NOT_common/v2.0\""
  }
}

The error detail:

   "message": "oidc: id token issued by a different provider, 
expected \"https://login.microsoftonline.com/common/v2.0\" 
got \"https://login.microsoftonline.com/AN_ID_WHICH_IS_NOT_common/v2.0\""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr 6027 Awaiting requested review from aeneasr aeneasr is a code owner

@zepatrik zepatrik Awaiting requested review from zepatrik

@hperl hperl Awaiting requested review from hperl

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwmay2012 @noells
0