Fix/orbit 6 issues #193
Fix/orbit 6 issues #193
Conversation
| @@ -31,6 +31,7 @@ public interface OrbitTestContext<STATE : Any, SIDE_EFFECT : Any, CONTAINER_HOST | |||
| /** | |||
| * Invoke an intent on the [ContainerHost] under test. | |||
| */ | |||
| @Deprecated("Use containerHost instead", ReplaceWith("action(containerHost)")) | |||
There was a problem hiding this comment.
Does this work with IntelliJ quickfix? Is it the reason for the all the thiss in this.containerHost.x()?
There was a problem hiding this comment.
Hmm, I guess there's no way to exclude the this. with the quickfix, because IJ adds it.
There was a problem hiding this comment.
Yep, I couldn't find a way to omit this. But this can be easily corrected using a search and replace within test scope so it's not as bad.
Yes, I would like to fix it quickly in a way that allows people to refactor (
|
Fixes for:
Blocking intents and other container host functions can be called via
containerHost.xxx()directly.I'm removing
invokeIntentto keep things consistent cc @mattmook , see discussion at #180 . TL;DR is that this change will allow people not to exposeJobfrom theirContainerHostif they don't need it in tests - I think this is the solution we missed originally.