8000 Pass scopes to HTTP client by jonesbusy · Pull Request #273 · oras-project/oras-java · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Pass scopes to HTTP client #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

Pass scopes to HTTP client #273

merged 1 commit into from
Apr 21, 2025

Conversation

jonesbusy
Copy link
Collaborator

Description

Still missing implement concurrent cache, but is just one step further

Testing done

mvn clean install

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

@codecov Codecov
Copy link
codecov bot commented Apr 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.01493% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.88%. Comparing base (81eaea8) to head (a1d71d0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/main/java/land/oras/auth/HttpClient.java 93.33% 0 Missing and 1 partial ⚠️
src/main/java/land/oras/auth/Scopes.java 94.44% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #273      +/-   ##
============================================
+ Coverage     87.57%   87.88%   +0.30%     
- Complexity      529      543      +14     
============================================
  Files            37       38       +1     
  Lines          1682     1725      +43     
  Branches        190      191       +1     
============================================
+ Hits           1473     1516      +43     
- Misses          133      134       +1     
+ Partials         76       75       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonesbusy
Pass scopes to HTTP client
a1d71d0 
Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
@jonesbusy jonesbusy force-pushed the feature/store-scopes branch from ba46606 to a1d71d0 Compare April 21, 2025 16:16
@jonesbusy jonesbusy marked this pull request as ready for review April 21, 2025 16:28
@jonesbusy jonesbusy merged commit be53b90 into oras-project:main Apr 21, 2025
4 checks passed
@jonesbusy jonesbusy deleted the feature/store-scopes branch April 21, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonesbusy
0