8000 Pass each time auth provider and handle token refresh on client instead of registry by jonesbusy · Pull Request #264 · oras-project/oras-java · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Pass each time auth provider and handle token refresh on client instead of registry #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged 8000

Pass each time auth provider and handle token refresh on client instead of registry #264

merged 1 commit into from
Apr 18, 2025

Conversation

jonesbusy
Copy link
Collaborator

Description

Pass each time auth provider and handle token refresh on client instead of registry

Partially fix #17 but without token caching

This is not performance since the token will be requested on each request.

Just parking this PR here

Testing done

mvn clean

Missing automated and interactive tests

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

@codecov Codecov
Copy link
codecov bot commented Apr 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.48649% with 15 lines in your changes missing coverage. Please review.

Project coverage is 87.42%. Comparing base (2c1ce0e) to head (6c73dd1).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/main/java/land/oras/utils/HttpClient.java 86.88% 5 Missing and 3 partials ⚠️
.../main/java/land/oras/auth/BearerTokenProvider.java 33.33% 4 Missing ⚠️
src/main/java/land/oras/Registry.java 94.59% 2 Missing ⚠️
src/main/java/land/oras/auth/NoAuthProvider.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #264      +/-   ##
============================================
+ Coverage     85.64%   87.42%   +1.78%     
+ Complexity      492      487       -5     
============================================
  Files            34       35       +1     
  Lines          1630     1583      -47     
  Branches        181      167      -14     
============================================
- Hits           1396     1384      -12     
+ Misses          155      130      -25     
+ Partials         79       69      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonesbusy
Pass each time auth provider
6c73dd1 
Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
@jonesbusy jonesbusy force-pushed the feature/better-token-support branch from 9627a80 to 6c73dd1 Compare April 18, 2025 05:36
@jonesbusy jonesbusy marked this pull request as ready for review April 18, 2025 06:57
@jonesbusy jonesbusy merged commit 6e16271 into oras-project:main Apr 18, 2025
4 checks passed
@jonesbusy jonesbusy deleted the feature/better-token-support branch April 18, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure performance and caching for authentication token
1 participant
@jonesbusy
0