8000 Use FileChannel.map for efficient digest computation by jorsol · Pull Request #217 · oras-project/oras-java · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use FileChannel.map for efficient digest computation #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2025
Merged

Use FileChannel.map for efficient digest computation #217

merged 2 commits into from
Mar 15, 2025

Conversation

jorsol
Copy link
Contributor
@jorsol jorsol commented Mar 14, 2025

Description

Use FileChannel.map for efficient file reading to compute digest, leveraging memory-mapped I/O for better performance.

Testing done

CI

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

jorsol added 2 commits March 14, 2025 22:21
@jorsol
Use java.util.HexFormat in DigestUtils
6492b47 
Signed-off-by: Jorge Solórzano <jorsol@gmail.com>
@jorsol
Use FileChannel.map for efficient digest computation
24cb60a 
Use FileChannel.map for efficient file reading to compute digest,
leveraging memory-mapped I/O for better performance.

Signed-off-by: Jorge Solórzano <jorsol@gmail.com>
@jorsol jorsol requested a review from jonesbusy as a code owner March 14, 2025 21:56
@codecov Codecov
Copy link
codecov bot commented Mar 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.43%. Comparing base (a2aa18c) to head (24cb60a).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main     #217   +/-   ##
=========================================
  Coverage     85.43%   85.43%           
+ Complexity      452      450    -2     
=========================================
  Files            33       33           
  Lines          1497     1497           
  Branches        176      173    -3     
=========================================
  Hits           1279     1279           
  Misses          144      144           
  Partials         74       74

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonesbusy jonesbusy added the enhancement New feature or request label Mar 15, 2025
@jonesbusy
Copy link
Collaborator

Thanks!

@jonesbusy jonesbusy merged commit 38220a8 into oras-project:main Mar 15, 2025
4 checks passed
@jorsol jorsol deleted the filechannel-read branch March 15, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonesbusy jonesbusy jonesbusy approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorsol @jonesbusy
0