OHRM5X-1754: Fix PIM - ESS attachment download #1488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22dace7 to
dd41e6e
Compare
…alidation when both are identical
e620a04 to
b501c12
Compare
5515fb9 to
9289fbd
Compare
Super-Chama
requested changes
Oct 13, 2022
| <oxd-dialog | ||
| v-if="show" | ||
| class="orangehrm-confirmation-dialog orangehrm-dialog-popup" | ||
| style="width: 450px" |
There was a problem hiding this comment.
i think .orangehrm-dialog-popup have width defined
There was a problem hiding this comment.
it has max-width defined. I put width to keep the box size consistent since I felt it was too small when only success text was there
| </div> | ||
| <div | ||
| class="orangehrm-text-center-align" | ||
| style="overflow-wrap: break-word" |
There was a problem hiding this comment.
refactor the style to class please
There was a problem hiding this comment.
it didn't work when putting as a class not sure why
| </oxd-text> | ||
| <oxd-text v-if="failed > 0" type="card-body"> | ||
| {{ failedRows.toString() }} | ||
| </oxd-text> |
There was a problem hiding this comment.
<template v-if="failed > 0">
<oxd-text type="card-body">
{{ $t('pim.n_records_failed_to_import', {count: failed}) }}
</oxd-text>
<oxd-text type="card-body">
{{ $t('pim.failed_rows') }}
</oxd-text>
<oxd-text type="card-body">
{{ failedRows.toString() }}
</oxd-text>
</template>
| }; | ||
| </script> | ||
|
|
||
| <style |
There was a problem hiding this comment.
better to add a stylesheet for this component.
There was a problem hiding this comment.
copy styles from dialog.scss into a new stylesheet for this component?
8000
| this.show = true; | ||
| }); | ||
| }, | ||
| onConfirm() { |
There was a problem hiding this comment.
since there is no confirmation in this dialog. better to remove these logic and use a simple v-if from parent component to show/hide the modal.
RajithaKumara
approved these changes
Oct 13, 2022
|
Fix for #1459 |
RajithaKumara
added a commit
to RajithaKumara/orangehrm
that referenced
this pull request
Oct 17, 2022
RajithaKumara
added a commit
to RajithaKumara/orangehrm
that referenced
this pull request
Oct 17, 2022
RajithaKumara
added a commit
that referenced
this pull request
Oct 17, 2022
* OHRM5X-1791: Add required asterisk marks in LDAP config screen * OHRM5X-1785: Update changelog * OHRM5X-1761: Revert EmployeeContactDetailsAPI change in #1488 * OHRM5X-1761: Improve work email and other email validation
Super-Chama
pushed a commit
to Super-Chama/orangehrm
that referenced
this pull request
Dec 13, 2022
…gehrm#1488) * OHRM5X-1754: Fix ESS users unable to download PIM attachments * OHRM5X-1759: [PIM- Data Import] User is able to import records having the same mail address for both work and other email and an error toast is displayed when the user tries to update the email * OHRM5X-1761: [PIM- Data Import] Issues related to Importing records having same employee id and email addresses
Super-Chama
pushed a commit
to Super-Chama/orangehrm
that referenced
this pull request
Dec 13, 2022
* OHRM5X-1791: Add required asterisk marks in LDAP config screen * OHRM5X-1785: Update changelog * OHRM5X-1761: Revert EmployeeContactDetailsAPI change in orangehrm#1488 * OHRM5X-1761: Improve work email and other email validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR contains: