yet another stats get prediction improvement #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or first request gets called again
optix2000
approved these changes
Sep 19, 2021
| r.Body = io.NopCloser(bytes.NewBuffer(body)) | ||
| body, _ := io.ReadAll(r.Body) | ||
| r.Body = io.NopCloser(bytes.NewBuffer(body)) | ||
| if strings.HasSuffix(string(body), "07ffffffff\x00") { |
There was a problem hiding this comment.
I assume 07ffffffff\x00 is the first R-Code call?
It might be better to pull it from the top of ExpectedRCodeCalls() so this always works as long as ExpectedRCodeCalls is kept up to date.
There was a problem hiding this comment.
Also removes duplicates of this magic string, since it's also used in AsyncGetStats()
607E
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset prediction if all expected requests are done or the first request gets called again.