Restrict range modifications on schema defined number pools #6608
+90
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #6608 will not alter performanceComparing Summary
|
ajtmccarty
reviewed
Jun 3, 2025
| ): | ||
| raise ValidationError( | ||
| input_value="start_range or end_range can't updated on schema defined pools, update the schema in the default branch instead" | ||
| ) |
There was a problem hiding this comment.
is this too late? if super().mutate_update(...) has already run, isn't the object already updated and saved?
There was a problem hiding this comment.
No since it's executed within a transaction any changes will be rolled back. We use this in a few places.
cf320eb to
af08ed6
Compare
ajtmccarty
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.