remove txn for diff calculation in pc pipeline #6594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #6594 will not alter performanceComparing Summary
|
ogenstad
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
there will be some unused nodes left behind in the database, but they will be ignored b/c the DiffRoot nodes will not have any of the metadata that we use to query for them.
Do we need to have some cleanup job for these? I.e. something that runs once a day and clears out entries older than a month or so..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this transaction is not necessary. the final step of diff update is to save the metadata for the diff (branch, from time, to time, etc.) and this acts as a final stamp indicating that the diff is complete. if the diff update fails for some reason, there will be some unused nodes left behind in the database, but they will be ignored b/c the
DiffRootnodes will not have any of the metadata that we use to query for them.