8000 Menu changes for trigger rules and actions by ogenstad · Pull Request #6487 · opsmill/infrahub · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Menu changes for trigger rules and actions #6487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

ogenstad
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label May 16, 2025
Copy link
codspeed-hq bot commented May 16, 2025

CodSpeed Performance Report

Merging #6487 will not alter performance

Comparing pog-menu-changes-for-triggers (53f5198) with develop (4d2976a)

Summary

✅ 10 untouched benchmarks

@ogenstad ogenstad marked this pull request as ready for review May 16, 2025 13:11
@ogenstad ogenstad requested a review from a team as a code owner May 16, 2025 13:11
MenuItemDefinition(
namespace="Builtin",
name="TriggerDefinition",
label="Triggers",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wvandeun @ogenstad @opsmill/customer-success
I think we should discuss how we would like to name that feature externally

Trigger is primarily an internal name so up to us if we want to name that differently externally

Copy link
Contributor
@wvandeun wvandeun May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion:
"Event actions > Event rules"
"Event actions > Event actions"

@ogenstad
Copy link
Contributor Author

As discussed in the daily merging this as is for now and then we can make iterations next week if we want to change it around.

@ogenstad ogenstad merged commit 5bd9599 into develop May 16, 2025
31 checks passed
@ogenstad ogenstad deleted the pog-menu-changes-for-triggers branch May 16, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0