Remove refs to InfrahubServices for git ops
#6406
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #6406 will not alter performanceComparing Summary
|
gmazoyer
commented
May 6, 2025
ogenstad
reviewed
May 6, 2025
|
|
||
| return self.service.client | ||
| return self.client |
There was a problem hiding this comment.
It could perhaps be a follow up PR but I think we should get rid of the sdk property.
9da3379 to
dbf453a
Compare
fa36fe1 to
0a68cd2
Compare
0a68cd2 to
2ee0889
Compare
This change tries to remove the need for a `InfrahubServices` object when it comes to operations to be performed on a git repository. This work is a stepping stone to be able to run user flagged workflows inside a dedicated prefect worker for isolation purpose as we won't be able to inject a `InfrahubServices` object into, also we don't want to for security reasons.
2ee0889 to
71ab8ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tries to remove the need for a
InfrahubServicesobject when it comes to operations to be performed on a git repository.This work is a stepping stone to be able to run user flagged workflows inside a dedicated prefect worker for isolation purpose as we won't be able to inject a
InfrahubServicesobject into, also we don't want to for security reasons.