8000 Javascript - Adding more completeness checks, adding missing JSX visit methods by greg-at-moderne · Pull Request #5657 · openrewrite/rewrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Javascript - Adding more completeness checks, adding missing JSX visit methods #5657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

greg-at-moderne
Copy link
Contributor
@greg-at-moderne greg-at-moderne commented Jun 23, 2025

What's changed?

Adding more completeness checks to Javascript LST element definitions.
And thanks to it:

  • adding missing visit JSX methods to some of the visitors

What's your motivation?

Prevent inconsistencies on subsequent LST changes for Javascript.

@greg-at-moderne greg-at-moderne self-assigned this Jun 23, 2025
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Jun 23, 2025
@greg-at-moderne greg-at-moderne marked this pull request as ready for review June 23, 2025 10:29
@greg-at-moderne greg-at-moderne merged commit 40e9e56 into main Jun 23, 2025
2 checks passed
@greg-at-moderne greg-at-moderne deleted the greg-js-more-Javascript-completeness branch June 23, 2025 10:29
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenRewrite Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant
0