Cleanup: ChangeParentPom recipe #5656
Merged
+88
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevanlingen
commented
Jun 23, 2025
| @@ -1653,53 +1711,6 @@ void shouldNotAddToDependencyManagement() { | |||
| )); | |||
| } | |||
|
|
|||
| @Test | |||
| void doesNotAddMavenDefaultProperties() { | |||
There was a problem hiding this comment.
💡 This test contained the same code as the doesNotAddGlobalProperties test.
jevanlingen
commented
Jun 23, 2025
|
|
||
| @Value | ||
| @EqualsAndHashCode(callSuper = false) | ||
| private static class UnconditionalAddProperty extends MavenIsoVisitor<ExecutionContext> { |
There was a problem hiding this comment.
💡 Contained nearly the same code as the AddPropertyVisitor.
jevanlingen
commented
Jun 23, 2025
| } | ||
| return resolvedGroupId.equals(dep.getGroupId()) && resolvedArtifactId.equals(dep.getArtifactId()); | ||
| .noneMatch(it -> { | ||
| String groupId = resolvedPom.getValue(it.getGroupId()); |
There was a problem hiding this comment.
💡 The getValue does already take properties into account:
timtebeek
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Nothing, just refactoring.
Checklist