UpgradeDependencyVersionTest recipe support for dependency-management plugin #5640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevanlingen
commented
Jun 19, 2025
| @@ -1437,6 +1512,38 @@ void kotlinDslStringInterpolation() { | |||
| ); | |||
| } | |||
|
|
|||
| @Test | |||
| void kotlinVersionInPropertiesFile() { | |||
There was a problem hiding this comment.
💡 This test does not really have anything to do with this PR; just an (already succeeding) missing test we need to have covered as well.
bmuschko
reviewed
Jun 19, 2025
There was a problem hiding this comment.
Please see my comment on the originating issue that drives the test cases. I personally think that we should not support the Spring Boot dependency management plugin directly. There should be a recipe that migrate away from it instead.
I am proposing not to add the tests in this PR until we make a decision.
|
Related PR: #5623 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Dependencies defined in a dependencyManagement block are updated as well.
What's your motivation?
Currently, using the Dependency Management plugin does not yield any changes.
Checklist