Recipe to find maven modules that have no parent #5639
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rewrite-maven/src/test/java/org/openrewrite/maven/search/ModuleHasNoParentTest.java
Show resolved
8000
Hide resolved
rewrite-maven/src/test/java/org/openrewrite/maven/search/ModuleHasNoParentTest.java
Outdated
Show resolved
Hide resolved
Laurens-W
reviewed
Jun 19, 2025
| return tree; | ||
| } | ||
| JavaProject jp = maybeJp.get(); | ||
| if (!acc.getProjectsWithParent().contains(jp)) { |
There was a problem hiding this comment.
What is the reasoning for this recipe being a scanning recipe?
I don't see why you couldn't just call parentPomInsight here and save the scanning cycle of the recipe :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added a recipe to mark Maven Modules that have no parent
What's your motivation?
When adding recipe (as part of it's changes) adds a maven parent, the current implementation of the AddParentPom recipe does notting when a parent is already present.
Especially when changes in the recipe depend on the correct parent being present this will cause unexpected and breaking changes.
With this recipe the module can be marked when there is no parent, so it can be used as a precondition for a recipe that requires the correct parent to be present.