JavaScript RPC changes #5636
Merged
JavaScript RPC changes #5636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add new `GetRef` and remove `ClearObjectMaps` * Add some tests * Simplify * Simplify * Simplify * Simplify
rewrite-core/src/main/java/org/openrewrite/rpc/request/GetRef.java
Outdated
Show resolved
Hide resolved
rewrite-core/src/main/java/org/openrewrite/rpc/request/GetRefResponse.java
Outdated
Show resolved
Hide resolved
rewrite-core/src/test/java/org/openrewrite/rpc/GetRefRequestTest.java
Outdated
Show resolved
Hide resolved
rewrite-core/src/test/java/org/openrewrite/rpc/IndependentCacheManagementTest.java
Outdated
Show resolved
Hide resolved
rewrite-core/src/main/java/org/openrewrite/rpc/request/GetRef.java
Outdated
Show resolved
Hide resolved
rewrite-core/src/main/java/org/openrewrite/rpc/request/GetRefResponse.java
Outdated
Show resolved
Hide resolved
rewrite-core/src/test/java/org/openrewrite/rpc/GetRefRequestTest.java
Outdated
Show resolved
Hide resolved
rewrite-core/src/test/java/org/openrewrite/rpc/IndependentCacheManagementTest.java
Outdated
Show resolved
Hide resolved
# Conflicts: # .claude/settings.local.json
sambsnyd
reviewed
Jun 24, 2025
Comment on lines
+38
to
+48
| @RequiredArgsConstructor | ||
| public static class Handler extends io.moderne.jsonrpc.JsonRpcMethod<GetRef> { | ||
| private static final ExecutorService forkJoin = ForkJoinPool.commonPool(); | ||
|
|
||
| private final Map<Integer, Object> remoteRefs; | ||
| private final IdentityHashMap<Object, Integer> localRefs; | ||
| private final AtomicInteger batchSize; | ||
| private final AtomicBoolean trace; | ||
|
|
||
| private final Map<Integer, BlockingQueue<List<RpcObjectData>>> inProgress = new ConcurrentHashMap<>(); | ||
|
|
There was a problem hiding this comment.
So is the idea here that one side or the other of an RPC setup owns the reference to a particular object and that can be used to figure out if it is safe to evict it from a cache?
There was a problem hiding this comment.
The idea is that either party should be allowed to cache both "objects" and "refs" (which ultimately might converge) without needing to coordinate the cache eviction with the other party. When a "ref" is unknown, it will then just send a "GetRef" request.
rewrite-core/src/main/java/org/openrewrite/internal/ManagedThreadLocal.java
Show resolved
Hide resolved
rewrite-core/src/main/java/org/openrewrite/internal/ManagedThreadLocal.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Changes
GetRefRPC request. This is very similar toGetObjectbut for "references"RewriteRpc.Contextand thread-local scope managementJsonRpcmust be provided at constructionmarketplaceis now a required parameter in all buildersbatchSizefrom builder API (usebatchSize()method instead)New Features
API Improvements
RewriteRpc.from(jsonRpc, marketplace).build()JavaScriptRewriteRpc.bind()Bug Fixes
OmitParenthesesandSemicolonThis refactoring significantly reduces complexity while improving memory management and API clarity.