8000 Keep comments where they are when removing method access modifiers by pdelagrave · Pull Request #5621 · openrewrite/rewrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Keep comments where they are when removing method access modifiers #5621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Keep comments where they are when removing method access modifiers #5621

wants to merge 6 commits into from

Conversation

pdelagrave
Copy link
@pdelagrave pdelagrave commented Jun 13, 2025 •
edited by timtebeek
Loading

What's changed?

wip

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Jun 13, 2025
@jevanlingen jevanlingen self-assigned this Jun 16, 2025
@jevanlingen jevanlingen removed their assignment Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
OpenRewrite
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChangeMethodAccessLevelVisitor should also consider Space
2 participants
@pdelagrave @jevanlingen
0