-
Notifications
You must be signed in to change notification settings - Fork 623
Update osm_poi_point only on change #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TomPohys
merged 1 commit into
openmaptiles:master
from
makina-maps:option_update_poi_point
Jun 29, 2021
Merged
Update osm_poi_point only on change #1129
TomPohys
merged 1 commit into
openmaptiles:master
from
makina-maps:option_update_poi_point
Jun 29, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Results evaluating commit 023f197 (merged with base 9600cec as a861c51). See run details. PostgreSQL DB size in MB: 2834 ⇒ 2785 (-1.7% change)
expand for details...
|
Thanks for the improvement! Could you please rebase it? Thanks a lot! |
5dd4950
to
023f197
Compare
Rebased. |
TomPohys
approved these changes
Jun 29, 2021
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After each diff import the table
osm_poi_point
is fully rewritten due to a full update of the field tags. It is now good to do an a update, event if the content does not change, postgres delete and reinsert internally the record. Resulting in more write and internal table size raising.Note: not directly linked, but there is a problem in this case, the autocaccum is not sufficient to keep this table size moderate, but grow indefinitely.